Skip to content

Conversation

zormit
Copy link

@zormit zormit commented Jul 10, 2024

What does this PR do, and why?

Upgrading urwid version, because why not. (description to be refined :P)

Outstanding aspect(s)

  • Waiting for feedback from CI (I only briefly checked whether the application still starts, but didn't fully test it with the upgraded requirement)

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Jul 10, 2024
@zormit zormit self-assigned this Jul 10, 2024
@zormit zormit added the PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback label Jul 10, 2024
@zormit zormit marked this pull request as draft July 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback size: XS [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants